Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Grunt Cordova command wrapping needs to accept CLI flags #97

Closed
diegonetto opened this issue Sep 6, 2014 · 0 comments
Closed

Grunt Cordova command wrapping needs to accept CLI flags #97

diegonetto opened this issue Sep 6, 2014 · 0 comments
Labels
enhancement

Comments

@diegonetto
Copy link
Owner

A few cordova commands accept CLI flags (such as emulate and build). The wrapper task needs to pass these flags onto cordova so that the following work as expected:

grunt build:ios --release --device

grunt emulate:ios --target=ipad

To support build on multiple platforms, current grunt build task needs to be renamed.
@diegonetto diegonetto mentioned this issue Sep 6, 2014
Closed
diegonetto added a commit that referenced this issue Oct 6, 2014
@diegonetto
feat(generator): Pass CLI flags to cordova wrapper functions. Closes #97
b2821f4 
 and #107
sidneys added a commit to sidneys/generator-ionic that referenced this issue Oct 9, 2014
@sidneys
Merge commit 'a14ecd0fadbdbfa3bd332361d86b6f3cdef08140'
988ee39 
* commit 'a14ecd0fadbdbfa3bd332361d86b6f3cdef08140': (39 commits)
  docs(docs): Add docs directory
  docs(readme): Plugin management
  docs(CHANGELOG): Update for 0.6.0
  0.6.0
  feat(ionic): Update to Beta 13
  fix(plugins): Add default plugins to be installed by new hooks
  feat(generator): Add support for Plugin management hooks. Closes diegonetto#72
  fix(generator): Fix issue when running emulate/run before serve
  fix(generator): Fix JSHint errors. Closes diegonetto#113
  docs(readme): Clean up some descriptions
  docs(readme): Add description for each command.
  docs(README): Begin documentation overhaul
  Update README.md
  Update README.md
  Update README.md
  Updated Readme with Android Walkthrough
  feat(generator): Pass CLI flags to cordova wrapper functions. Closes diegonetto#97 and diegonetto#107
  feat(generator): Add ionic-cli support. Closes diegonetto#112
  feature(generator): Add support for Plugin management hooks. Closes diegonetto#72
  bug(generator): Fix issue when running emulate/run before serve
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@diegonetto