2-spaces indentation, added vendor folder with README.md, updated Gruntf... #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntfile with copy:vendor , added placeholders for vendor files in index.html
diegonetto
added a commit
that referenced
this pull request
Mar 4, 2014
2-spaces indentation, added vendor folder with README.md, updated Gruntf...
|
Looks good. Thanks for adding the README file as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added the 2-space indent we agreed upon, and also provided the vendor folder with Grunt support. In the last week, I had to manually add two libraries (JS and JS/CSS) manually, and it's not a no-brainer when there is no bower support, as there may be more to come. I agree with you diegonetto that libs should be added through bower, but sometimes there is no support for bower. Perhaps it won't be needed in the future, but at the moment I use it with http://momentjs.com/ (min + lang version, provided by bower but not possible to include via bower) and https://github.com/driftyco/ionic-contrib-frosted-glass which is not provided by bower.
I added a README.md file to the folder, that provides arguments for it's addition :) and also easy instructions on how to use it.