Add analysis of unsafe code in dependencies through cargo geiger #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metajack
suggested changes
Jun 21, 2021
analysis/src/code.rs
Outdated
|
|
||
| fn get_unsafe_report(&self, name: String, version: String) -> Result<Option<UnsafeReport>> { | ||
| let key = (name, version); | ||
| let cache = self.geiger_cache.borrow(); |
There was a problem hiding this comment.
Maybe there should be a get_cargo_geiger_report that grabs one from the cache based on the key? That would hide the cache a bit from the other code.
There was a problem hiding this comment.
Probably it would return Option<CargoGeigerReport>.
metajack
approved these changes
Jun 22, 2021
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes made
Add processing of cargo geiger report for unsafe code
Improvement TODO