Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove internal copy of Path#strip_prefix when 1.7 is stable #183

Closed
mcasper opened this issue Feb 3, 2016 · 3 comments
Closed

Remove internal copy of Path#strip_prefix when 1.7 is stable #183

mcasper opened this issue Feb 3, 2016 · 3 comments
Labels
cli good first issue

Comments

@mcasper
Copy link
Contributor

mcasper commented Feb 3, 2016

Specific issue for a FIXME per #173

As of b1a215b, this FIXME is located here: https://github.com/sgrif/diesel/blob/master/diesel_cli/src/main.rs#L289
@sgrif
Copy link
Member

sgrif commented Feb 3, 2016

Permalink: https://github.com/sgrif/diesel/blob/b1a215b/diesel_cli/src/main.rs#L289

@sgrif sgrif added the cli label Feb 3, 2016
@sgrif sgrif changed the title [CLI] Remove internal copy of Path#strip_prefix when 1.7 is stable Remove internal copy of Path#strip_prefix when 1.7 is stable Feb 3, 2016
@emptyflash
Copy link
Contributor

Just to be clear, relative_from isn't being used because it's marked unstable (rust-lang/rust#23284), so once 1.7 is stable we should replace strip_prefix with Path#strip_prefix?

@emptyflash emptyflash mentioned this issue Mar 3, 2016
Merged
@mcasper
Copy link
Contributor Author

mcasper commented Mar 4, 2016

Resolved by #230

@mcasper mcasper closed this as completed Mar 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cli good first issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sgrif @emptyflash @mcasper