Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove any remaining FIXMEs related to SQLite support #173

Closed
sgrif opened this issue Feb 2, 2016 · 0 comments
Closed

Remove any remaining FIXMEs related to SQLite support #173

sgrif opened this issue Feb 2, 2016 · 0 comments
Labels
good first issue sqlite
Milestone
0.5

Comments

@sgrif
Copy link
Member

sgrif commented Feb 2, 2016

This is a blanket reminder issue, as I'm not sure I have an individual issue for each of these. Any that can be resolved for 0.5 should. Any that we are not going to fix in 0.5 should still be removed, and have a separate issue opened for them.

If you're reading this and you've found a specific comment which doesn't have an issue, please open one.
@sgrif sgrif added this to the 0.5 milestone Feb 2, 2016
@mcasper mcasper changed the title [SQLite] Remove any remainging FIXMEs [SQLite] Remove any remaining FIXMEs Feb 3, 2016
@mcasper mcasper mentioned this issue Feb 3, 2016
Closed
@sgrif sgrif changed the title [SQLite] Remove any remaining FIXMEs Remove any remaining FIXMEs related to SQLite support Feb 3, 2016
sgrif added a commit that referenced this issue Feb 5, 2016
@sgrif
Fix remaining FIXMEs that are going to be fixed in 0.5
fb19528 
This adds two new missing features to `SQLite`. A `ToSql` impl for
`Bool`, and an implementation of `save_changes`. I wanted to keep the
blanket impl for `SupportsReturningKeyword`, but it looks like I can't
rely on `Sqlite` not implementing it from the user's crate. I think this
will just get moved in crate once we solve #179 anyway.

There are still some remaining things to be addressed, such as the lack
of support for numeric and date types, but those are out of scope for
0.5.

Fixes #173.
@sgrif sgrif mentioned this issue Feb 5, 2016
Merged
@sgrif sgrif closed this as completed in #195 Feb 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue sqlite
Projects
None yet
Milestone
0.5
Development

No branches or pull requests
1 participant
@sgrif