remove confusing panic messages from examples #2218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
woah, are all these failures my fault? |
|
The ci is broken on beta because of rust-lang/rust#66295 |
|
Could you rebase this to fix the CI? |
r-arias
force-pushed
the
fix/examples-update-unwrap-or-else
branch
from
23b4f02
to
4980c9b
Compare
|
Done, I think :) |
weiznich
reviewed
Dec 7, 2019
| .find(id) | ||
| .first(&connection) | ||
| .unwrap_or_else(|_| panic!("Unable to find post {}", id)); | ||
| let post: Post = posts.find(id).first(&connection).unwrap(); |
There was a problem hiding this comment.
The error message was correct in that case, or do I miss something?
There was a problem hiding this comment.
uh, I might have been too quick there. let me look at it again.
The `publish_post` examples contained a confusing `panic!()` that suggested the update statement would return an error, when a post to be updated could not be found. In reality, however, that case results in an `Ok(0)` value. To avoid confusion, this commit replaces the panicking `unwrap_or_else()` calls with a simpler `unwrap()`.
r-arias
force-pushed
the
fix/examples-update-unwrap-or-else
branch
from
4980c9b
to
2e1f9e4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
publish_postexamples contained a confusingpanic!()thatsuggested the update statement would return an error, when a post to be
updated could not be found. In reality, however, that case results in an
Ok(0)value.To avoid confusion, this commit replaces the panicking
unwrap_or_else()calls with a simplerunwrap().