Remove support for old uuid versions #2268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uuid 0.7.0 was released back in 2018 introducing breaking changes to API's diesel is using internally. Because we exposed in our public api we couldn't remove it back then. The next release will be diesel 2.0, so a breaking change is now possible. Give the time span since the release of the initial compatible version I'm in favour of removing support for even older version, as support for them comes with a lot of code duplication. (As it turns out this support was already broken in our master branch because we don't test it anymore...)
weiznich
force-pushed
the
fix/uuid_support
branch
from
8e6aeec
to
699ae58
Compare
|
Hm, this still has a conflict and CI doesn't run :/ |
|
nightly failures are deprecation warnings, would you include the fix or follow-up later? |
|
Ah, wait, it's just a warning, overflow occurs, and it's reported on rust-lang/rust. |
|
Yes nightly failures are because of rust-lang/rust#68264. So if someone approves the change I see no reason not to merge it yet. |
JohnTitor
approved these changes
Jan 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
uuid 0.7.0 was released back in 2018 introducing breaking changes to
API's diesel is using internally. Because we exposed in our public api
we couldn't remove it back then.
The next release will be diesel 2.0, so a breaking change is now
possible. Give the time span since the release of the initial
compatible version I'm in favour of removing support for even older
version, as support for them comes with a lot of code duplication. (As
it turns out this support was already broken in our master branch
because we don't test it anymore...)