Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dotenv to 0.15 #2410

Merged
merged 1 commit into from
May 25, 2020
Merged

Update dotenv to 0.15 #2410

merged 1 commit into from
May 25, 2020

Conversation

JohnTitor
Copy link
Member

Since we head 2.0 release, I think we could allow losing older dotenv support here.

@weiznich weiznich requested a review from a team May 25, 2020 08:46
@weiznich weiznich added the maybe backport Maybe backport this pr to the latest diesel release label May 25, 2020
@weiznich
Copy link
Member

As we don't export dotenv as public dependency anywhere I think that can be done unrelated to the 2.0 release, therefore I'm marking this as maybe backport so that we would potentially include it in a 1.4.x release (if we issue another one)

@weiznich weiznich merged commit 2b4340d into diesel-rs:master May 25, 2020
@JohnTitor JohnTitor deleted the dotenv branch May 25, 2020 12:04
@JohnTitor JohnTitor mentioned this pull request Jul 1, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pksunkara pksunkara pksunkara approved these changes

Assignees
No one assigned
Labels
maybe backport Maybe backport this pr to the latest diesel release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JohnTitor @weiznich @pksunkara