GitHub actions/backport #2416
Merged
GitHub actions/backport #2416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If that actually works I'm proposing moving all of our ci/automation
to this service, because of:
* Integration with github seems to be vastly better
+ No need to click n times to go to logs
+ Rerun a failed job is easier
+ Maybe? Inline error messages in PR's
* Error messages are automatically extracted
* I think they have 20 free concurrent jobs, azure has only 10 (so
faster CI)
(Most of the config is copied from wundergraph)
This reverts commit b436ec3.
* bcrypt is an internal dependency so this does not really matter * diesel_derive requires at least syn 1.0.1, but that's an internal dependency so we can just "bump" it * num is a mess, that combination works. As this only lowers the lower bound it should not be a breaking change
weiznich
force-pushed
the
github_actions/backport
branch
from
dd2954b
to
b7fc260
Compare
(Yes we know that's UB, but that was ok there …)
0.2 as 0.1 is just broken
Add a Cargo.lock file with dependencies matching that old nightly. Should be fine as compile_tests have a seperate workspace and we don't publish anything from there.
weiznich
force-pushed
the
github_actions/backport
branch
from
8770bda
to
75c6d20
Compare
weiznich
force-pushed
the
github_actions/backport
branch
from
5a7ef44
to
bf05b94
Compare
weiznich
force-pushed
the
github_actions/backport
branch
from
bf05b94
to
8448e4b
Compare
|
This is related to #2269, but I think we can also remove AppVeyor config, cannot we? Seems it's totally outdated and Actions now check on Windows as well. |
pksunkara
approved these changes
May 31, 2020
JohnTitor
approved these changes
Jun 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Back port of #2269 as proposed there