Allow custom backends to overwrite QueryFragment impls for SelectStatement and BoxedSelectStatement
#3257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weiznich
force-pushed
the
make_selectstatement_query_fragment_impl_customizable
branch
from
76da616 to
b577db0
Compare
…tatement` and `BoxedSelectStatement` This commit introduces the necessary associated type to `SqlDialect` so that custom backends can provide custom `QueryFragment` implementations for `SelectStatement` and `BoxedSelectStatement`. This is required as some database systems require a different order of clauses there. (The `firebird` backend is using a custom fork for this currently). All existing backends in diesel will just use the existing implementations. In addition this commit extends the `__diesel_public_if` macro to conditionally make struct fields public as well. As it's not possible to apply proc-macro attributes directly to struct fields, this is solved by having an explicit list of "public" fields in the macro call on the struct itself. Such structs are also marked as `#[non_exhaustive]` so that we can add additional fields later on.
weiznich
force-pushed
the
make_selectstatement_query_fragment_impl_customizable
branch
from
b577db0 to
d756d63
Compare
This was referenced Aug 4, 2022
Merged
|
Nightly builds fail due to rust-lang/rust#100620 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces the necessary associated type to
SqlDialectsothat custom backends can provide custom
QueryFragmentimplementationsfor
SelectStatementandBoxedSelectStatement. This is required assome database systems require a different order of clauses there. (The
firebirdbackend is using a custom fork for this currently).All existing backends in diesel will just use the existing
implementations.
In addition this commit extends the
__diesel_public_ifmacro toconditionally make struct fields public as well. As it's not possible to
apply proc-macro attributes directly to struct fields, this is solved by
having an explicit list of "public" fields in the macro call on the
struct itself. Such structs are also marked as
#[non_exhaustive]sothat we can add additional fields later on.
See fernandobatels/rsfbclient#127 for a possible use case