Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rust toolchain update #3396

Merged
merged 3 commits into from
Nov 7, 2022
Merged

Rust toolchain update #3396

merged 3 commits into from
Nov 7, 2022

Conversation

weiznich
Copy link
Member

@weiznich weiznich commented Nov 7, 2022

No description provided.

@weiznich weiznich requested a review from a team November 7, 2022 13:08
Copy link
Member

@Ten0 Ten0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like we also need to port over these changes

Copy link
Member

@Ten0 Ten0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple curiosity, why does this not go with updating .github/workflows/ci.yml ?

@weiznich
Copy link
Member Author

weiznich commented Nov 7, 2022

Simple curiosity, why does this not go with updating .github/workflows/ci.yml ?

Because the only jobs that specify exact rust versions instead of just channels (stable/beta/nightly) are the minimal version job, the compile tests job and the asan job. The first one uses an older rust version, while the later ones require a nightly version.

@weiznich weiznich merged commit 53cdd3f into diesel-rs:master Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants