cli setup improvements

[dennybiasiolli]

• cli: using fs::create_dir_all in create_migrations_directory

  To recursively create a directory and all of its parent components if they are missing.

• cli: writing the custom migration dir to the config file

• cli: fixing windows paths in toml strings and adding a specific test for that

[dennybiasiolli]

@weiznich rebased, to check if tests are passing now 😉

[weiznich]

Thanks for opening this PR 👍 I'm generally fine with how this change is implemented and what it is supposed to change. The CI test failures on windows seem to be related to the change (and likely to the review comment left for the create_config_file function). That needs to be fixed before merging as we also need to support windows there.

[dennybiasiolli]

@weiznich I just found the reason for test errors: tests on windows are receiving an absolute path as migrations_dir and they crash on windows for that reason.
With this workaround I managed to solve the problem for tests, but a cleaner solution would be to pass a relative path when testing.
Any idea?

[weiznich]

As this might also be a potential problem if someone passes an absolute path manually to the CI, I would prefer an solution that just converts the path to an path relative to the diesel.toml file instead. Maybe just call Path::strip_prefix?

[dennybiasiolli]

Let's try with another solution, the problem could be that the string wrote in the .toml file must be escaped and I'm not doing that.

I'm trying with

        let migrations_dir_toml_string = format!(
            "dir = \"{}\"",
            migrations_dir.display().to_string().replace('\\', "\\\\")
        );

Workflow here: https://github.com/dennybiasiolli/diesel/actions/runs/8005969731
Fingers crossed!

[dennybiasiolli]

Ok now it works! https://github.com/dennybiasiolli/diesel/actions/runs/8007224538
Let me use the same fix in this branch

[dennybiasiolli]

"STDERR: Failed to execute a database query: Identifier name 'diesel_setup_writes_migration_dir_by_arg_to_config_file_escaping_windows_paths' is too long"

This should be an easy fix 😰

[dennybiasiolli]

The only failing check error now is this one:
MBERROR: The remote file either doesn't exist, is unauthorized, or is forbidden for url 'https://dev.mysql.com/get/Downloads/MySQL-8.0/mysql-8.0.31-winx64.zip'. Exception calling "Read" with "3" argument(s): "Unable to read data from the transport connection: An existing connection was forcibly closed by the remote host."

I think it shouldn't be. problem, but feel free to re-run the workflow just to be 100% sure 😉