Help cargo to break dependency cycle caused by dev deps #3980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pksunkara
approved these changes
Apr 6, 2024
|
Doesn't that possibly break some doc links? |
|
I don't see how it could break doc links. To have any undocumented types you'd have to use types from the dev dependency in a non-test build of the library, and that is not allowed and won't compile. |
kornelski
force-pushed
the
dev-cycle
branch
2 times, most recently
from
75eb67f to
1a093de
Compare
Ten0
approved these changes
Apr 7, 2024
|
The failing CI is caused by a regression in rustc. I've filled rust-lang/rust#123622 for that. |
auto-merge was automatically disabled
April 9, 2024 14:18
Head branch was pushed to by a user without write access
|
Would it be possible to rebase this PR on top of the latest master version to pull in the fixes for the CI setup? (Sorry for that…) |
|
Thanks for submitting this PR ❤️ |
weiznich
added a commit
that referenced
this pull request
Apr 19, 2024
Help cargo to break dependency cycle caused by dev deps
Ten0
added a commit
to Ten0/serde_avro_fast
that referenced
this pull request
Jun 14, 2024
This in fact has no impact on rustdoc according to diesel-rs/diesel#3980 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cargo can automatically remove
pathdependencies when publishing when they don't have aversionspecified.This way it should be possible to publish crates without editing their
Cargo.toml, and therefore keep their vcs metadata.