jsonb_pretty function
#4254
Merged
jsonb_pretty function
#4254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guissalustiano
suggested changes
Sep 11, 2024
There was a problem hiding this comment.
Thanks for opening the PR!
The changes look good, I only would like to see some tests with NULL input (I explain the reason in yours other PR.
| /// | ||
| /// assert_eq!(r#"{ | ||
| /// }"#, result); | ||
| /// # Ok(()) |
There was a problem hiding this comment.
Could you add a test case with a None input?
weiznich
reviewed
Sep 11, 2024
| /// # Ok(()) | ||
| /// # } | ||
| /// ``` | ||
| fn jsonb_pretty<E: JsonbOrNullableJsonb + SingleValue>(e: E) -> Text; |
There was a problem hiding this comment.
Suggested change
| fn jsonb_pretty<E: JsonbOrNullableJsonb + SingleValue>(e: E) -> Text; | |
| fn jsonb_pretty<E: JsonbOrNullableJsonb + MaybeNullableValue<Text> + SingleValue>(e: E) -> E::Out; |
to correctly handle null value inputs.
See the longer explanation here how this works. (You are not expected to know this on your own, I just don't want to copy this comment everywhere)
|
Thank you for the suggestion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added th
jsonb_prettyfunction under Issue#4216