[WIP] Feature/infer enums #994
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* It only works with postgres
* This extends the enum support indroduced in the last commit, to support enums across different database instances (It does not depend on the oid now)
Wrap the actuall connection into an new type to not expose it to ToSql
|
Can you remove all the enum stuff from this PR? I'd like to focus only on the runtime lookup of OIDs for now |
|
Opened #995 for the runtime lookup part. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow up for #940
This is a first draft version to get some feedback on this.
Things to fix before merging:
Using an implementation similar to the shown, will restrict the produced binary to exactly the same database that was used to compile the code because the type oid's of the enums are hardcoded in
HasSqlType::metadata. As far as I understand those oid's could/will change if you run your migrations on a other database instance, so the provided mapping will be invalid.As far as I see there are two possible solutions:
Fixes #343