This repository has been archived by the owner on May 25, 2020. It is now read-only.
Implemented support for the "exclude-pattern" parameter #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cpascu do you want to check if this works for you? |
morozov
force-pushed
the
exclude-pattern
branch
2 times, most recently
from
5ffbc5d
to
8b5cafc
Compare
|
@morozov I've tested and it's working, merging into my fork until this makes it into master. Thanks! |
|
@cpascu thank you. I'm not merging it yet since the issue which causes the issue on Windows also exists on other platforms but doesn't make the suite fail. I'll need some more time to figure out what's going on. |
morozov
force-pushed
the
exclude-pattern
branch
2 times, most recently
from
1e46ef4
to
33730c0
Compare
As of squizlabs/PHP_CodeSniffer#1488, Filter::accept() doesn't strictly check the real path of the files, so intstead of using reflection and calling its protected methods, we can use the filter itself. Closes #4.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of squizlabs/PHP_CodeSniffer#1488,
Filter::accept()doesn't strictly check the real path of the files, so instead of using reflection and calling its protected methods, we can use the filter itself.Closes #4.