receivers for http/tcp/web socket communication #152

eleniv3d · 2025-05-15T20:06:08Z

This PR includes:
(1) an http listener that retrieves .ply files from the internet
https://github.com/user-attachments/assets/59ce5c8d-adad-4164-9414-49cebac1f652

(2) a TCP listener that receives pcd color data
https://github.com/user-attachments/assets/a088ad9c-712a-49ea-90fb-4b6deb1e583e

(3) a Websocket listener that receives pcd color data
https://github.com/user-attachments/assets/8310f586-0c51-4769-babe-9453556af1a6

To test the files you can use the senders that are available here and here

The workflow now is:

start server in gh (press i_start_btn)
start sending with vs code
load pcd in gh (press i_load_btn)

I added automatic btns and panels for standard inputs like we had for the visualization_settings component and moved these utilities to a new df_gh_canvas.py file so that they are available to use in components in the future. The components look like this when dropped in the carvas :

eleniv3d · 2025-05-16T10:05:10Z

@DamienGilliard , @9and3
I run pre-commit but linter doesn't like the ghenv.Component.Message without importing ghenv but I think it only works like this :)

9and3 · 2025-05-16T15:10:35Z

@DamienGilliard , @9and3 I run pre-commit but linter doesn't like the ghenv.Component.Message without importing ghenv but I think it only works like this :)

You can flag the line with an in-line comment

param = ghenv.Component.Params.Input[indx]  # noqa: F821

see

diffCheck/src/gh/components/DF_csv_exporter/code.py

Lines 30 to 42 in a73bc9d

    
           param = ghenv.Component.Params.Input[indx]  # noqa: F821 
        
           if param.SourceCount == 0: 
        
               toggle = gh.Kernel.Special.GH_BooleanToggle() 
        
               toggle.NickName = nickname 
        
               toggle.Description = "Toggle the value to use with DFVizSettings" 
        
               toggle.CreateAttributes() 
        
               toggle.Attributes.Pivot = System.Drawing.PointF( 
        
                   X_param_coord - (toggle.Attributes.Bounds.Width) - X_offset, 
        
                   Y_param_coord - (toggle.Attributes.Bounds.Height / 2 + 0.1) 
        
                   ) 
        
               toggle.Attributes.ExpireLayout() 
        
               gh.Instances.ActiveCanvas.Document.AddObject(toggle, False) 
        
               ghenv.Component.Params.Input[indx].AddSource(toggle)  # noqa: F821

The linter should stop complaining about it :)

eleniv3d · 2025-05-27T12:51:34Z

@DamienGilliard , @9and3 I run pre-commit but linter doesn't like the ghenv.Component.Message without importing ghenv but I think it only works like this :)

You can flag the line with an in-line comment
param = ghenv.Component.Params.Input[indx]  # noqa: F821
see

diffCheck/src/gh/components/DF_csv_exporter/code.py

Lines 30 to 42 in a73bc9d

param = ghenv.Component.Params.Input[indx] # noqa: F821

if param.SourceCount == 0:

toggle = gh.Kernel.Special.GH_BooleanToggle()

toggle.NickName = nickname

toggle.Description = "Toggle the value to use with DFVizSettings"

toggle.CreateAttributes()

toggle.Attributes.Pivot = System.Drawing.PointF(

X_param_coord - (toggle.Attributes.Bounds.Width) - X_offset,

Y_param_coord - (toggle.Attributes.Bounds.Height / 2 + 0.1)

)

toggle.Attributes.ExpireLayout()

gh.Instances.ActiveCanvas.Document.AddObject(toggle, False)

ghenv.Component.Params.Input[indx].AddSource(toggle) # noqa: F821

The linter should stop complaining about it :)

Thanks @9and3! it seems to have done the trick ;)

Patch: CI + gh fixes

eleniv3d · 2025-06-17T15:55:47Z

All three are working now!

Remains to be verified if I successfully added websockets to the python package or it just works on my side because I had it already installed. :)

DamienGilliard · 2025-06-17T16:41:14Z

I'll try and let you know before the meeting tomorrow

DamienGilliard · 2025-06-17T19:35:40Z

@eleniv3d Works fine on my side !

… settings

DamienGilliard

Small questions here and there, but overall thanks a lot for this great addition!

DamienGilliard · 2025-06-26T15:50:53Z

src/gh/diffCheck/diffCheck/df_gh_canvas.py

I don't know if I'm being picky, but it seems to me that calling the file df_gh_canvas_utils.py would be more explicit. Otherwise thanks for this new module !

DamienGilliard · 2025-06-26T15:53:03Z

src/gh/components/DF_tcp_listener/code.py

+            df_gh_canvas.add_button(
+                ghenv.Component, label, idx, x_offset=60)  # noqa: F821
+        df_gh_canvas.add_panel(ghenv.Component, "Host", "127.0.0.1", 3, 60, 20)  # noqa: F821
+        df_gh_canvas.add_panel(ghenv.Component, "Port", "5000", 4, 60, 20)  # noqa: F821


DamienGilliard · 2025-06-26T16:05:30Z

src/gh/components/DF_tcp_listener/code.py

+        sc.sticky.setdefault(f'{prefix}_prev_load', False)
+
+        # Client handler
+        def handle_client(conn):


Could you add doctrings (here and elsewhere) in your functions that describe the types of data needed ? It is not clear to me what "conn" is :( . For example:

def handle_client(conn: <type_of_conn>): """ reads the incoming bytes from a single client socket and stores valid data in a shared buffer :param conn: <what conn is in pain english> :returns: <what it returns> """

Like what you did for some of the functions in the new df_gh_canvas.py module.
I noticed that I had not done it myself so I'll fix it and put full docstring everywhere too ;)

DamienGilliard · 2025-06-26T16:15:30Z

src/gh/components/DF_tcp_listener/code.py

+            with conn:
+                while sc.sticky.get(f'{prefix}_server_started', False):
+                    try:
+                        chunk = conn.recv(4096)
+                        if not chunk:
+                            break
+                        buf += chunk
+                        while b'\n' in buf:
+                            line, buf = buf.split(b'\n', 1)
+                            try:
+                                raw = json.loads(line.decode())
+                            except Exception:
+                                continue
+                            if isinstance(raw, list) and all(isinstance(pt, list) and len(pt) == 6 for pt in raw):
+                                sc.sticky[f'{prefix}_cloud_buffer_raw'] = raw
+                    except Exception:
+                        break


In my experience, having infinite loops in separate threads that run "full gas" can lead to issues with the cpu, I would add a small time.sleep(0.1) for 100ms sleep before re-running the loop, for example.
Although here on my computer this loop without pause seems to have no negative impact

DamienGilliard · 2025-06-26T16:23:42Z

src/gh/components/DF_tcp_listener/code.py

+        if i_start and not sc.sticky[f'{prefix}_prev_start']:
+            start_server()


When testing your components I made the mistake to first try to send data to the TCP socket (before starting the server, dumb of me) and it lead me to think that maybe we could add after this if something like:

else: self.AddRuntimeMessage(RML.Warning, "Please start server here before trying to send data from remote device.")

Maybe it is because I'm dumb but I think it could improve slightly the user-friendliness

DamienGilliard · 2025-06-26T16:51:08Z

src/gh/components/DF_websocket_listener/code.py

+            cnt = len(sc.sticky[f'{prefix}_loaded_pcd']) if sc.sticky[f'{prefix}_loaded_pcd'] else 0
+            logs.append(f"Loaded pcd with {cnt} pts")
+            ghenv.Component.ExpireSolution(True)  # noqa: F821
+


Here too, as for the TCP listener, I would add a small warning to start server in gh before trying to send data. It sounds obvious but I think it's a nice-to-have feature. Let us know what you think ;)

DamienGilliard · 2025-06-26T16:53:21Z

src/gh/diffCheck/diffCheck.egg-info/PKG-INFO

-Dynamic: author
-Dynamic: author-email
-Dynamic: classifier
-Dynamic: description
-Dynamic: description-content-type
-Dynamic: home-page
-Dynamic: requires-dist
-Dynamic: summary


Why have these been deleted? is it intentional ?

DamienGilliard · 2025-07-22T09:10:16Z

src/gh/components/DF_websocket_listener/code.py

+        prefix = 'ws'
+
+        # Persistent state across runs
+        sc.sticky.setdefault(f'{prefix}_ws_server', None)
+        sc.sticky.setdefault(f'{prefix}_ws_loop',   None)
+        sc.sticky.setdefault(f'{prefix}_ws_thread', None)
+        sc.sticky.setdefault(f'{prefix}_last_pcd',  None)
+        sc.sticky.setdefault(f'{prefix}_loaded_pcd', None)
+        sc.sticky.setdefault(f'{prefix}_ws_logs',   [])
+        sc.sticky.setdefault(f'{prefix}_ws_thread_started', False)
+        sc.sticky.setdefault(f'{prefix}_prev_start', False)
+        sc.sticky.setdefault(f'{prefix}_prev_stop',  False)
+        sc.sticky.setdefault(f'{prefix}_prev_load',  False)


having ws_ws_server and other ws_ws names seems strange to me. Is it necessary ?

ADD Http Listener

136e3dc

eleniv3d changed the title ~~clients for http/tcp/web socket communication~~ receivers for http/tcp/web socket communication May 15, 2025

ADD TCP Listener

38aab63

FIX lintering

2fd80df

eleniv3d added 5 commits May 27, 2025 17:46

FIX tcp component + add example file sender

aeecaa2

Merge pull request #148 from diffCheckOrg/patch_ws

5559ade

Patch: CI + gh fixes

Merge branch 'main' into IO

5cacef1

WIP FIX WS Receiver

4aafbf8

FIX websocket component

e09fb79

eleniv3d added 2 commits June 22, 2025 14:10

FIX light refactoring and input reorder

46c6d6f

ADD drop btns and panel with standard inputs similar to vizualization…

c546fec

… settings

eleniv3d marked this pull request as ready for review June 22, 2025 14:05

DamienGilliard reviewed Jul 22, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

receivers for http/tcp/web socket communication #152

receivers for http/tcp/web socket communication #152

Uh oh!

eleniv3d commented May 15, 2025 •

edited

Loading

Uh oh!

eleniv3d commented May 16, 2025

Uh oh!

9and3 commented May 16, 2025

Uh oh!

eleniv3d commented May 27, 2025

Uh oh!

eleniv3d commented Jun 17, 2025

Uh oh!

DamienGilliard commented Jun 17, 2025

Uh oh!

DamienGilliard commented Jun 17, 2025

Uh oh!

DamienGilliard left a comment

Uh oh!

DamienGilliard Jun 26, 2025

Uh oh!

DamienGilliard Jun 26, 2025

Uh oh!

DamienGilliard Jun 26, 2025

Uh oh!

DamienGilliard Jun 26, 2025

Uh oh!

DamienGilliard Jun 26, 2025

Uh oh!

DamienGilliard Jun 26, 2025

Uh oh!

DamienGilliard Jun 26, 2025

Uh oh!

DamienGilliard Jul 22, 2025

Uh oh!

Uh oh!

		if i_start and not sc.sticky[f'{prefix}_prev_start']:
		start_server()

receivers for http/tcp/web socket communication #152

Are you sure you want to change the base?

receivers for http/tcp/web socket communication #152

Uh oh!

Conversation

eleniv3d commented May 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

eleniv3d commented May 16, 2025

Uh oh!

9and3 commented May 16, 2025

Uh oh!

eleniv3d commented May 27, 2025

Uh oh!

eleniv3d commented Jun 17, 2025

Uh oh!

DamienGilliard commented Jun 17, 2025

Uh oh!

DamienGilliard commented Jun 17, 2025

Uh oh!

DamienGilliard left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

eleniv3d commented May 15, 2025 •

edited

Loading