Silence #if/#elif warnings originating from Windows header files #2455
Conversation
tautschnig
requested review from
kroening,
peterschrammel and
smowton
as code owners
allredj
left a comment
allredj
left a comment
There was a problem hiding this comment.
This PR failed Diffblue compatibility checks (cbmc commit: 6cb461c).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/77212176
Status will be re-evaluated on next push.
Please contact @peterschrammel, @thk123, or @allredj for support.
Common spurious failures:
- the cbmc commit has disappeared in the mean time (e.g. in a force-push)
- the author is not in the list of contributors (e.g. first-time contributors).
tautschnig
force-pushed
the
vs-win-headers
branch
from
6cb461c to
9947bfb
Compare
tautschnig
assigned
smowton,
kroening,
peterschrammel and
pkesseli and unassigned
tautschnig
smowton
left a comment
smowton
left a comment
There was a problem hiding this comment.
I'm obviously surprised if windows.h triggers warnings on a Microsoft compiler, but if it's really the case then this seems like an acceptable way to deal with that. Could you provide a specific example of the kind of construct that it's complaining about in your commit message?
allredj
left a comment
allredj
left a comment
There was a problem hiding this comment.
Passed Diffblue compatibility checks (cbmc commit: 9947bfb).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/78383405
tautschnig
force-pushed
the
vs-win-headers
branch
from
9947bfb to
e3c035d
Compare
|
I have amended the commit message as suggested. |
allredj
left a comment
allredj
left a comment
There was a problem hiding this comment.
Passed Diffblue compatibility checks (cbmc commit: e3c035d).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/78385938
|
Thanks! Also whenever we eventually bump required MSVC to 2017, we can use this: https://blogs.msdn.microsoft.com/vcblog/2017/12/13/broken-warnings-theory/ |
On AppVeyor, we got the following warnings: C:\Program Files (x86)\Windows Kits\8.1\include\um\processthreadsapi.h(1170) : warning C4668: '_WIN32_WINNT_WINTHRESHOLD' is not defined as a preprocessor macro, replacing with '0' for '#if/#elif' C:\Program Files (x86)\Windows Kits\8.1\include\um\winbase.h(8618) : warning C4668: 'NTDDI_WIN7SP1' is not defined as a preprocessor macro, replacing with '0' for '#if/#elif'
tautschnig
force-pushed
the
vs-win-headers
branch
from
e3c035d to
9144556
Compare
|
Sad, but I don't have a better idea. |
6 participants
No description provided.