Skip to content

Cleanup uses of std::move #3589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 18, 2018
Merged

Conversation

tautschnig
Copy link
Collaborator

Just remove std::move in case an unnamed object is returned, remove named
temporaries that add no value, and don't use const with std::move.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

Just remove std::move in case an unnamed object is returned, remove named
temporaries that add no value, and don't use const with std::move.
@kroening
Copy link
Member

I am sad about the interaction of const and the conversion to rvalue reference on return.

Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️
Passed Diffblue compatibility checks (cbmc commit: e08eb2f).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/95145326

@peterschrammel peterschrammel removed their assignment Dec 18, 2018
@tautschnig tautschnig merged commit c16e0ff into diffblue:develop Dec 18, 2018
@tautschnig tautschnig deleted the std-move-cleanup branch December 18, 2018 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants