Revert "Symex: resolve pointer comparisons using the value-set" #4656
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owen-mc-diffblue
requested review from
chrisr-diffblue,
kroening,
martin-cs and
peterschrammel
as code owners
allredj
reviewed
May 15, 2019
Contributor
allredj
left a comment
allredj
left a comment
There was a problem hiding this comment.
✔️
Passed Diffblue compatibility checks (cbmc commit: b3467f0).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/111947412
tautschnig
added a commit
to tautschnig/cbmc
that referenced
this pull request
May 16, 2019
This is to guard against the regression earlier introduced in diffblue#4444 (and reverted in diffblue#4656).
3 tasks
owen-mc-diffblue
deleted the
revert-4444-value-set-filtering-infeasible-branch
branch
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #4444
A bug was found - see #4444 for discussion.