SMT-LIB2 parameter/let/quantifier scopes #5158
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allredj
reviewed
Oct 8, 2019
Contributor
allredj
left a comment
allredj
left a comment
There was a problem hiding this comment.
✔️
Passed Diffblue compatibility checks (cbmc commit: c75b2ab).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/131005570
kroening
force-pushed
the
smt2_function_scoping_test
branch
2 times, most recently
from
8569ea4 to
48a1390
Compare
kroening
requested review from
martin-cs,
peterschrammel,
romainbrenguier and
tautschnig
as code owners
kroening
changed the title
SMT-LIB2 function definitions have scopes for the identifiers of the parameters. The same holds for let expressions. This was raised in #5143. The need to make the scoped identifiers unique will be removed once the IR bindings have scopes.
kroening
force-pushed
the
smt2_function_scoping_test
branch
from
48a1390 to
6eabb66
Compare
kroening
changed the title
allredj
reviewed
Oct 9, 2019
Contributor
allredj
left a comment
allredj
left a comment
There was a problem hiding this comment.
✔️
Passed Diffblue compatibility checks (cbmc commit: 6eabb66).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/131189813
peterschrammel
approved these changes
Oct 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SMT-LIB2 function definitions have scopes for the identifiers of the parameters.
This was raised in #5143.