Fix havocing of arrays when enforcing invariants #6026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SaswatPadhi
requested review from
chrisr-diffblue,
martin-cs,
peterschrammel and
smowton
as code owners
SaswatPadhi
added
aws
Codecov Report
@@ Coverage Diff @@
## develop #6026 +/- ##
===========================================
+ Coverage 74.11% 74.12% +0.01%
===========================================
Files 1444 1444
Lines 157389 157401 +12
===========================================
+ Hits 116646 116676 +30
+ Misses 40743 40725 -18
Continue to review full report at Codecov.
|
|
@SaswatPadhi Please update |
tautschnig
approved these changes
Apr 13, 2021
regression/contracts/invar_havoc_dynamic_multi-dim_array_partial_const_idx/test.desc
Show resolved
Hide resolved
SaswatPadhi
force-pushed
the
invariant_deref_fix
branch
2 times, most recently
from
2a67069 to
b5ad550
Compare
TGWDB
approved these changes
Apr 14, 2021
As reported in diffblue#6020, only the first element of an array was being havoced earlier. In this change, we fix this behavior using `havoc_object`.
These regression tests currently fail due to imprecision in alias analysis (see: diffblue#6021). In future, we could either improve the alias analysis, or add manual assigns clause annotations on these loops and make sure that the arrays are correctly havoced.
SaswatPadhi
force-pushed
the
invariant_deref_fix
branch
from
b5ad550 to
9c7f6f7
Compare
chrisr-diffblue
approved these changes
Apr 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6020.
As reported in #6020, only the first element of an array was being havoced earlier. In this change, we fix this behavior using
havoc_object.The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/My commit message includes data points confirming performance improvements (if claimed).White-space or formatting changes outside the feature-related changed lines are in commits of their own.