Skip to content

Conversation

@thomasspriggs
Copy link
Contributor

This directory dependency should have been added when the dependency on
the ansi-c library was added to the symtab2gb makefile. This currently
missing dependency results in sporadic build failures.

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • White-space or formatting changes outside the feature-related changed lines are in commits of their own.

This directory dependency should have been added when the dependency on
the ansi-c library was added to the symtab2gb makefile. This currently
missing dependency results in sporadic build failures.
Copy link
Collaborator

@martin-cs martin-cs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry; my fault. Thanks for catching this.

@codecov
Copy link

codecov bot commented Aug 2, 2021

Codecov Report

Merging #6264 (a528058) into develop (3a2de48) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #6264   +/-   ##
========================================
  Coverage    76.16%   76.16%           
========================================
  Files         1484     1484           
  Lines       162164   162164           
========================================
  Hits        123516   123516           
  Misses       38648    38648           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 932d41d...a528058. Read the comment docs.

@martin-cs martin-cs merged commit 5d4b780 into diffblue:develop Aug 3, 2021
@martin-cs
Copy link
Collaborator

Does CMake handle this kind of dependency automatically?

@thomasspriggs thomasspriggs deleted the tas/fix_ansi-c_symtab_dependency branch August 3, 2021 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants