Skip to content

goto-analyzer --(un)reachable-functions should not rely on base names #6338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 21, 2021

Conversation

tautschnig
Copy link
Collaborator

Functions are called by their symbol names, not their base names. The
output may still safely use the base name for more user-friendly
results, but call trees should not rely on a match of base names and
symbol names.

Fixes: #6330

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

Copy link
Collaborator

@martin-cs martin-cs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable.

@codecov
Copy link

codecov bot commented Sep 20, 2021

Codecov Report

Merging #6338 (ac069cf) into develop (5e4fc98) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #6338      +/-   ##
===========================================
- Coverage    75.90%   75.90%   -0.01%     
===========================================
  Files         1515     1515              
  Lines       164002   164004       +2     
===========================================
+ Hits        124482   124483       +1     
- Misses       39520    39521       +1     
Impacted Files Coverage Δ
src/goto-analyzer/unreachable_instructions.cpp 90.95% <100.00%> (-0.42%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f4a680...ac069cf. Read the comment docs.

Functions are called by their symbol names, not their base names. The
output may still safely use the base name for more user-friendly
results, but call trees should not rely on a match of base names and
symbol names.

Fixes: diffblue#6330
@tautschnig tautschnig merged commit 9c1b5ea into diffblue:develop Sep 21, 2021
@tautschnig tautschnig deleted the fix-6330-part-2 branch September 21, 2021 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aws Bugs or features of importance to AWS CBMC users aws-high bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Link order matters with --export-file-local-symbols
5 participants