Skip to content

Conversation

@tautschnig
Copy link
Collaborator

As already done in other variants of run, decode the exit status using
WEXITSTATUS.

I only noticed this mistake when using --external-sat-solver, which reported weird exit codes (and now reports the expected exit codes instead).

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@codecov
Copy link

codecov bot commented Apr 1, 2022

Codecov Report

Merging #6779 (e02f4da) into develop (6127938) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop    #6779   +/-   ##
========================================
  Coverage    76.90%   76.90%           
========================================
  Files         1590     1590           
  Lines       183970   183971    +1     
========================================
+ Hits        141485   141486    +1     
  Misses       42485    42485           
Impacted Files Coverage Δ
src/util/run.cpp 75.63% <100.00%> (+0.20%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2bf999e...e02f4da. Read the comment docs.

As already done in other variants of `run`, decode the exit status using
WEXITSTATUS.
@tautschnig tautschnig force-pushed the bugfixes/exit-code branch from ca2fe44 to e02f4da Compare April 1, 2022 20:31
@kroening kroening merged commit 7df1571 into diffblue:develop Apr 6, 2022
@tautschnig tautschnig deleted the bugfixes/exit-code branch April 6, 2022 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants