Skip to content

Conversation

@tautschnig
Copy link
Collaborator

The GCC version configures how our C lexer operates. Not setting it
before running the C parser may cause spurious syntax errors, for
example when parsing the system math headers. Tools that potentially
link the built-in library will need to be able to parse those headers
successfully.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

The GCC version configures how our C lexer operates. Not setting it
before running the C parser may cause spurious syntax errors, for
example when parsing the system math headers. Tools that potentially
link the built-in library will need to be able to parse those headers
successfully.
@tautschnig tautschnig force-pushed the bugfixes/set-gcc-version branch from ec84223 to b2b2734 Compare April 9, 2022 19:34
@tautschnig tautschnig removed their assignment Apr 9, 2022
@codecov
Copy link

codecov bot commented Apr 9, 2022

Codecov Report

Merging #6789 (b2b2734) into develop (b7c6692) will increase coverage by 0.07%.
The diff coverage is 89.64%.

@@             Coverage Diff             @@
##           develop    #6789      +/-   ##
===========================================
+ Coverage    76.90%   76.98%   +0.07%     
===========================================
  Files         1590     1593       +3     
  Lines       183969   184121     +152     
===========================================
+ Hits        141486   141740     +254     
+ Misses       42483    42381     -102     
Impacted Files Coverage Δ
..._incremental/smt2_incremental_decision_procedure.h 75.00% <ø> (ø)
...c/solvers/smt2_incremental/convert_expr_to_smt.cpp 84.87% <76.74%> (+12.78%) ⬆️
src/solvers/smt2_incremental/object_tracking.cpp 97.87% <97.87%> (ø)
src/goto-analyzer/goto_analyzer_parse_options.cpp 72.27% <100.00%> (+0.33%) ⬆️
src/goto-diff/goto_diff_parse_options.cpp 60.22% <100.00%> (+1.89%) ⬆️
.../goto-instrument/goto_instrument_parse_options.cpp 69.54% <100.00%> (+0.14%) ⬆️
src/goto-programs/goto_function.cpp 100.00% <100.00%> (ø)
src/solvers/smt2_incremental/object_tracking.h 100.00% <100.00%> (ø)
...ncremental/smt2_incremental_decision_procedure.cpp 94.15% <100.00%> (+0.14%) ⬆️
...t/solvers/smt2_incremental/convert_expr_to_smt.cpp 100.00% <100.00%> (ø)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a4c66e...b2b2734. Read the comment docs.

Copy link
Contributor

@TGWDB TGWDB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A pity we still have to parse the same option in several places for different tools.

@tautschnig
Copy link
Collaborator Author

A pity we still have to parse the same option in several places for different tools.

Ack, and while it would be possible to have function to replace those 5 lines by just one function call, that function call would still be in slightly different places in each of the locations touched in this PR.

@tautschnig tautschnig added aws Bugs or features of importance to AWS CBMC users aws-high labels May 6, 2022
@peterschrammel peterschrammel removed their assignment May 17, 2022
@tautschnig tautschnig merged commit d483694 into diffblue:develop May 17, 2022
@tautschnig tautschnig deleted the bugfixes/set-gcc-version branch May 17, 2022 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

aws Bugs or features of importance to AWS CBMC users aws-high bugfix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants