CONTRACTS: Support slice targets in loop assigns clauses #7127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remi-delmas-3000
requested review from
tautschnig,
feliperodri,
SaswatPadhi,
martin-cs,
chris-ryder,
peterschrammel and
kroening
as code owners
6 tasks
Codecov ReportBase: 78.31% // Head: 78.49% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #7127 +/- ##
===========================================
+ Coverage 78.31% 78.49% +0.17%
===========================================
Files 1667 1667
Lines 191475 191516 +41
===========================================
+ Hits 149958 150330 +372
+ Misses 41517 41186 -331
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
feliperodri
added
aws
feliperodri
changed the title
|
@remi-delmas-3000 Is the "dependent-do-not-merge" tag still appropriate for this? Looks like the dependency was merged. Is it time to rebase and wake up the reviewers on this one? |
jimgrundy
reviewed
Nov 25, 2022
remi-delmas-3000
force-pushed
the
assigns-slice-loop-contracts
branch
from
a32fbba to
92ff1c3
Compare
|
@feliperodri @qinheping @tautschnig can I get a quick review of this one ? It is needed for #7541 |
remi-delmas-3000
force-pushed
the
assigns-slice-loop-contracts
branch
2 times, most recently
from
5eee562 to
2411dec
Compare
tautschnig
requested changes
Feb 15, 2023
remi-delmas-3000
force-pushed
the
assigns-slice-loop-contracts
branch
2 times, most recently
from
f578d92 to
a3a10cb
Compare
feliperodri
approved these changes
Feb 15, 2023
tautschnig
approved these changes
Feb 16, 2023
tautschnig
reviewed
Feb 16, 2023
regression/contracts/loop_assigns-slice-assignable-scalar/test.desc
Outdated
Show resolved
Hide resolved
Changes: - Drop support for __CPROVER_POINTER_OBJECT in assigns clauses in the front-end - Add methods to havoc __CPROVER_assignable, __CPROVER_object_whole, __CPROVER_object_from, __CPROVER_object_upto in havoc_assigns_targett. - update tests - add new tests
remi-delmas-3000
force-pushed
the
assigns-slice-loop-contracts
branch
from
a3a10cb to
39118f4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #7086 (first two commits).
Fixes #6979.
Drop support for
__CPROVER_POINTER_OBJECTin function contract and loop assigns clauses. Extend support for__CPROVER_typed_target,__CPROVER_assignable,__CPROVER_object_whole,__CPROVER_object_from,__CPROVER_object_uptoto loop contracts.