Skip to content

Conversation

@tautschnig
Copy link
Collaborator

This is rejected by GCC, and we should equally refuse to process this.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

This is rejected by GCC, and we should equally refuse to process this.
@tautschnig tautschnig force-pushed the feature/ptr-diff-mixed-types branch from 6e09602 to 206cf2a Compare December 15, 2022 10:00
@codecov
Copy link

codecov bot commented Dec 15, 2022

Codecov Report

Base: 78.40% // Head: 78.41% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (206cf2a) compared to base (540a60f).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #7441   +/-   ##
========================================
  Coverage    78.40%   78.41%           
========================================
  Files         1659     1659           
  Lines       190379   190382    +3     
========================================
+ Hits        149276   149280    +4     
+ Misses       41103    41102    -1     
Impacted Files Coverage Δ
...cts/dynamic-frames/dfcc_lift_memory_predicates.cpp 89.50% <ø> (ø)
src/ansi-c/c_typecheck_expr.cpp 75.75% <100.00%> (+0.06%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tautschnig tautschnig merged commit d158216 into diffblue:develop Dec 15, 2022
@tautschnig tautschnig deleted the feature/ptr-diff-mixed-types branch December 15, 2022 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants