Make CPROVER intrinsics proper prototypes #7533
Merged
+327
−284
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tautschnig
force-pushed
the
cleanup/library-decls
branch
2 times, most recently
from
2419eeb to
3140a77
Compare
We previously maintained a function call, which would end up being type in-consistent if there were multiple uses of `__CPROVER_enum_is_in_range` with distinct enum types. Instead, have the C front-end create an (and immediately lower) an expression. The only bit of care that's currently required is to ensure that goto_check_ct does not end up creating assertions over the resulting expression.
tautschnig
force-pushed
the
cleanup/library-decls
branch
2 times, most recently
from
ed24286 to
e822aa9
Compare
Forward declarations without arguments are deprecated in C. Polymorphic built-ins now have dummy declarations that are only in effect when running library checks. Our own C front-end will type check them properly and won't rely on forward declarations.
tautschnig
force-pushed
the
cleanup/library-decls
branch
from
e822aa9 to
7ff9285
Compare
C uses '(void)' to denote this, not an empty list of parameters.
Clang 15 complains about GNU-style line markers (`# <number>` instead of `#line <number>`), which we don't need to do anything about. Fixes: diffblue#7525
tautschnig
force-pushed
the
cleanup/library-decls
branch
from
7ff9285 to
04886f5
Compare
tautschnig
requested review from
chris-ryder,
kroening,
peterschrammel and
remi-delmas-3000
as code owners
martin-cs
approved these changes
Feb 15, 2023
Collaborator
martin-cs
left a comment
martin-cs
left a comment
There was a problem hiding this comment.
Very glad it wasn't me who fixed this one.
peterschrammel
approved these changes
Feb 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forward declarations without arguments are deprecated in C.