Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid brew symlink conflict in macos-13 #8338

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

tautschnig
Copy link
Collaborator

@tautschnig tautschnig commented Jun 17, 2024

GitHub images already have maven installed, and upgrading to the latest version of maven via brew results in symlink conflicts of the python 3.12 dependency (earlier reported in actions/runner-images#4020).

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@tautschnig tautschnig self-assigned this Jun 17, 2024
GitHub images already have maven installed, and upgrading to the latest
version of maven via brew results in symlink conflicts of the python
3.12 dependency (earlier reported in
  actions/runner-images#4020).
@tautschnig tautschnig changed the title [do not review] macos-13 CI debugging Avoid brew symlink conflict in macos-13 Jun 17, 2024
@tautschnig tautschnig marked this pull request as ready for review June 17, 2024 20:40
@tautschnig tautschnig requested review from peterschrammel and a team as code owners June 17, 2024 20:40
@tautschnig tautschnig assigned peterschrammel and TGWDB and unassigned tautschnig Jun 17, 2024
Copy link

codecov bot commented Jun 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.37%. Comparing base (0acd97d) to head (97e615f).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #8338   +/-   ##
========================================
  Coverage    78.37%   78.37%           
========================================
  Files         1726     1726           
  Lines       188322   188322           
  Branches     18444    18460   +16     
========================================
  Hits        147606   147606           
  Misses       40716    40716           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tautschnig tautschnig merged commit 8646bfa into diffblue:develop Jun 17, 2024
40 checks passed
@tautschnig tautschnig deleted the debug-macos-13 branch June 17, 2024 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants