-
Notifications
You must be signed in to change notification settings - Fork 264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for building with GCC 14 #8368
Conversation
1cdd354
to
f8e0c9c
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #8368 +/- ##
===========================================
- Coverage 78.34% 78.34% -0.01%
===========================================
Files 1726 1726
Lines 188437 188415 -22
Branches 18244 18248 +4
===========================================
- Hits 147638 147607 -31
- Misses 40799 40808 +9 ☔ View full report in Codecov by Sentry. |
GCC 14 adds new warnings. Those are largely spurious (perhaps with exception of the interpreter code and unit tests), but still require working around. These warnings also affect CaDiCaL builds, which in turn requires us to upgrade to version 2.0.0, where workarounds have been added. Fixes: diffblue#7749
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems the analysis trips over local namespacet and irep_idt instances, which are harmless, but it can't know that.
GCC 14 adds new warnings. Those are largely spurious (perhaps with exception of the interpreter code), but still require working around. These warnings also affect CaDiCaL builds, which in turn requires us to upgrade to version 2.0.0, where workarounds have been added.
Fixes: #7749