Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for building with GCC 14 #8368

Merged
merged 1 commit into from
Jul 10, 2024

Conversation

tautschnig
Copy link
Collaborator

GCC 14 adds new warnings. Those are largely spurious (perhaps with exception of the interpreter code), but still require working around. These warnings also affect CaDiCaL builds, which in turn requires us to upgrade to version 2.0.0, where workarounds have been added.

Fixes: #7749

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@tautschnig tautschnig self-assigned this Jul 5, 2024
@tautschnig tautschnig force-pushed the gcc-14-compat branch 5 times, most recently from 1cdd354 to f8e0c9c Compare July 5, 2024 15:13
Copy link

codecov bot commented Jul 5, 2024

Codecov Report

Attention: Patch coverage is 88.09524% with 5 lines in your changes missing coverage. Please review.

Project coverage is 78.34%. Comparing base (66ae03f) to head (560a588).

Files Patch % Lines
unit/util/graph.cpp 20.00% 4 Missing ⚠️
src/goto-programs/interpreter.cpp 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8368      +/-   ##
===========================================
- Coverage    78.34%   78.34%   -0.01%     
===========================================
  Files         1726     1726              
  Lines       188437   188415      -22     
  Branches     18244    18248       +4     
===========================================
- Hits        147638   147607      -31     
- Misses       40799    40808       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

GCC 14 adds new warnings. Those are largely spurious (perhaps with
exception of the interpreter code and unit tests), but still require
working around.  These warnings also affect CaDiCaL builds, which in
turn requires us to upgrade to version 2.0.0, where workarounds have
been added.

Fixes: diffblue#7749
@tautschnig tautschnig assigned TGWDB and unassigned kroening Jul 9, 2024
Copy link
Member

@peterschrammel peterschrammel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems the analysis trips over local namespacet and irep_idt instances, which are harmless, but it can't know that.

@tautschnig tautschnig merged commit 40572a1 into diffblue:develop Jul 10, 2024
39 of 40 checks passed
@tautschnig tautschnig deleted the gcc-14-compat branch July 10, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compilation Error due to danling-reference warning with -Werror
6 participants