Skip to content

Contracts instrumentation: cleanup unnecessary includes #8696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

tautschnig
Copy link
Collaborator

Reduce includes in header files to a minimum and avoid including what isn't required. (It seems that IWYU did not catch these.)

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

Copy link

codecov bot commented Jul 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.39%. Comparing base (4a1a325) to head (9098aab).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8696      +/-   ##
===========================================
- Coverage    80.40%   80.39%   -0.01%     
===========================================
  Files         1688     1688              
  Lines       207403   207403              
  Branches        73       73              
===========================================
- Hits        166763   166749      -14     
- Misses       40640    40654      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Reduce includes in header files to a minimum and avoid including what
isn't required. (It seems that IWYU did not catch these.)
@tautschnig tautschnig force-pushed the contracts-cleanup-includes branch from 7441548 to 9098aab Compare July 25, 2025 12:40
Copy link
Collaborator

@feliperodri feliperodri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for this clean up! How come our linters didn't catch these 👀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants