Option for the valid-memcleanup property #63
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The option is --memory-cleanup-check. There must be a separate option because memory leaks for programs containing an error are handled differently for the memsafety and the memcleanup properties.
There was a problem hiding this comment.
I've had ported that fix to a "newer" CBMC version here: diffblue/cbmc#3462
But that's also a while ago now...
|
This should be merged -- I once forgot to include this option resulting in unnecessary wrong results :) |
|
I have now pushed an update to diffblue/cbmc#3462 to make things work with current CBMC. |
tautschnig
approved these changes
Nov 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a difference between valid-memtrack and valid-memcleanup properties in SV-COMP. The difference is that memleaks occurring on
reach_errorshould be reported only for the valid-memcleanup property.This PR adds a new CLI option
--memory-cleanup-check.I added this option to the CBMC version that we use for 2LS here. The idea is that memory leak assertions for abort-like functions are only added if this CLI option is used.
This is implemented on a very old version of CBMC, though, so I'm not sure if it'll be possible to easily port it to the current version. If not, I can move this option into the 2LS wrapper script.