Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Persist service definition #47

Merged
merged 5 commits into from
Jan 8, 2024
Merged

feat: Persist service definition #47

merged 5 commits into from
Jan 8, 2024

Conversation

nadeesha
Copy link
Contributor

@nadeesha nadeesha commented Jan 8, 2024

Persists service definition optionally supplied through the nextJobs call.

Copy link

vercel bot commented Jan 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
console ⬜️ Ignored (Inspect) Visit Preview Jan 8, 2024 10:17am

@nadeesha nadeesha marked this pull request as ready for review January 8, 2024 07:47
Copy link

New dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
prettier 3.1.1 filesystem, environment +0 8.42 MB prettier-bot

Copy link
Collaborator

@johnjcsmith johnjcsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. This is going to be handy.

@nadeesha nadeesha merged commit dba4831 into main Jan 8, 2024
8 checks passed
@nadeesha nadeesha deleted the send-service-def branch January 8, 2024 10:24
nadeesha added a commit that referenced this pull request Jan 8, 2024
Persists service definition optionally supplied through the `nextJobs`
call.
nadeesha added a commit that referenced this pull request Jan 12, 2024
Renders service function details based on service definition (#47) in
the admin console.

<img width="1319" alt="image"
src="https://github.com/differentialhq/differential/assets/9162298/c11c4875-a9e6-4654-bc35-25a83e61db59">

This removes the temporary metrics which were aggregated the "jobs"
table for now, these will be replaced with metrics from the metrics
endpoint (#43).

---------

Co-authored-by: Nadeesha Cabral <n@nadeesha.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants