Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Local JAR Support #20

Merged
merged 5 commits into from
May 28, 2021
Merged

Local JAR Support #20

merged 5 commits into from
May 28, 2021

Conversation

chris-serra
Copy link
Contributor

@chris-serra chris-serra commented May 27, 2021 •
edited
Loading

Fixes #12

@chris-serra chris-serra marked this pull request as draft May 27, 2021 01:51
@chris-serra chris-serra marked this pull request as ready for review May 27, 2021 03:09
nedtwigg
nedtwigg requested changes May 28, 2021
View reviewed changes
Copy link
Member

@nedtwigg nedtwigg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation looks sound! Some housekeeping before I can merge :)

CHANGELOG.md Outdated Show resolved Hide resolved
src/main/java/com/diffplug/blowdryer/Blowdryer.java Outdated Show resolved Hide resolved
src/main/java/com/diffplug/blowdryer/Blowdryer.java Show resolved Hide resolved
src/main/java/com/diffplug/blowdryer/BlowdryerSetup.java Outdated Show resolved Hide resolved
@chris-serra chris-serra requested a review from nedtwigg May 28, 2021 07:18
@chris-serra
Copy link
Contributor Author

@nedtwigg Would you like me to update the README's "How to use"?

Also, the repoSubFolder isn't used for the Local JAR, as src/main/resources folder structure is not included in a built JAR file (from what I've seen).

@nedtwigg
Copy link
Member

Yes please on both counts!

@nedtwigg nedtwigg merged commit 6ac0e71 into diffplug:main May 28, 2021
@nedtwigg
Copy link
Member

I'm working on publishing the newest version. Feel free to submit a new PR with doc improvements at your leisure.

@chris-serra chris-serra mentioned this pull request May 29, 2021
Merged
@nedtwigg
Copy link
Member

Published in 1.2.0

@chris-serra
Copy link
Contributor Author

@nedtwigg Updated README in #22

@chris-serra chris-serra deleted the local-jar-support branch May 30, 2021 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nedtwigg nedtwigg Awaiting requested review from nedtwigg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Extracting resources from jar
2 participants
@chris-serra @nedtwigg