Skip to content

Add mapping for jdt compiler #158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 13, 2021
Merged

Add mapping for jdt compiler #158

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@

## [Unreleased]

### Fixed
- Fix ecj mapping in eclipseMavenCentral ([#158](https://github.com/diffplug/goomph/pull/158))

## [3.32.1] - 2021-09-09

### Fixed
Expand Down
4 changes: 3 additions & 1 deletion src/main/java/com/diffplug/gradle/eclipse/MavenCentralMapping.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,9 @@ public static boolean isEclipseGroup(String group) {

/** Returns the MavenCentral groupId:artifactId appropriate for the given bundleId. */
public static String groupIdArtifactId(String bundleId) {
if (bundleId.startsWith(JDT)) {
if ("org.eclipse.jdt.core.compiler.batch".equals(bundleId)) {
return JDT + ":ecj";
} else if (bundleId.startsWith(JDT)) {
return JDT + ":" + bundleId;
} else if (bundleId.startsWith(PDE)) {
return PDE + ":" + bundleId;
Expand Down