Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jdt enhancements #23

Merged
merged 6 commits into from
Dec 2, 2016
Merged

Jdt enhancements #23

merged 6 commits into from
Dec 2, 2016

Commits on Dec 1, 2016

  1. Configuration menu
    Copy the full SHA
    ef655df View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e4cd898 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    10aa587 View commit details
    Browse the repository at this point in the history

Commits on Dec 2, 2016

  1. Use ImmutableList.

    scottresnik committed Dec 2, 2016
    Configuration menu
    Copy the full SHA
    5c53ab4 View commit details
    Browse the repository at this point in the history
  2. Moved new JdtConvention actions to be local, where possible.

    When a DSL method gets called (e.g. compilerComplicanceLevel), ideally we would call extension.workspaceProp() or extension.addSetupAction() right there, immediately.  That keeps everything local, so there are fewer places to debug.
    
    There are cases, such as installedJres, where you have aggregate several calls to a method into a single action.  In that case, we can use the `close()` method to know that the user has finished calling methods, and we can now take our aggregated actions.
    nedtwigg committed Dec 2, 2016
    Configuration menu
    Copy the full SHA
    7434506 View commit details
    Browse the repository at this point in the history
  3. Refactored OomphIdeExtension.linkedResource to be local, and to lazil…

    …y resolve the file.
    
    
    In a gradle DSL, anytime you want a File, you can do `project.file(Object input)` and it will give you a file.  That way the input can be a File or a relative path, and gradle will resolve it to relative to the project.
    nedtwigg committed Dec 2, 2016
    Configuration menu
    Copy the full SHA
    503cde4 View commit details
    Browse the repository at this point in the history