Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support google-java-format --skip-javadoc-formatting? #1287

Closed
kevinb9n opened this issue Aug 22, 2022 · 1 comment · Fixed by #1793
Closed

Support google-java-format --skip-javadoc-formatting? #1287

kevinb9n opened this issue Aug 22, 2022 · 1 comment · Fixed by #1793

Comments

@kevinb9n
Copy link

Just noticed that this command-line option doesn't seem to be supported by GoogleJavaFormatConfig.

google-java-format is of course very stingy with options, but does allow some behaviors to be switched on or off, like this.

Should this be handled like #929 - is there a similar rationale?

@nedtwigg
Copy link
Member

A PR along the lines of #929 is very welcome :) Optionally, you might want to also do

while you're at it. Feel free to drop support for older GJF versions if you need to, but try to stay as compatible as possible.

mokamoto12 added a commit to mokamoto12/spotless that referenced this issue Aug 30, 2023
Add configuration option to switch the option of the googleJavaFormat step.
Default to format javadoc for backwards compatibility.

Fixes diffplug#1287
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants