Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

M2E Support: Emit file specific errors during incremental build #1960

Closed
kwin opened this issue Dec 8, 2023 · 0 comments · Fixed by #1962
Closed

M2E Support: Emit file specific errors during incremental build #1960

kwin opened this issue Dec 8, 2023 · 0 comments · Fixed by #1962
Labels
enhancement

Comments

@kwin
Copy link
Contributor

kwin commented Dec 8, 2023

The m2e support added in #1413 currently only supports the "apply" goal properly but not the "check" goal as the error marker API from https://github.com/codehaus-plexus/plexus-build-api/blob/d7055dc45530a679b8f1ff62c0aa5562101d40a7/src/main/java/org/codehaus/plexus/build/BuildContext.java#L216 is not used, but rather a generic exception is being emitted in

spotless/plugin-maven/src/main/java/com/diffplug/spotless/maven/SpotlessCheckMojo.java

Line 76 in 3fce314

throw new MojoExecutionException(DiffMessageFormatter.builder()
which lacks that crucial file context information.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Emit contextual error message during incremental m2e builds kwin/spotless
2 participants
@kwin @nedtwigg