Add support for enforcing line endings from .gitattributes

[nedtwigg]

@chkpnt submitted a great PR #22 which allows different line endings for different formats. After discussion, we've decided to instead implement support for the .gitattributes eol property.

Provisionally, support will look like this:

spotless {
    lineEndings GITATTRIBUTES
}

This should probably have been the default behavior all along, but it's a breaking change compared to the current default, lineEndings PLATFORM_NATIVE. As a result I think I'll make this next release version 2.0 to alert users to check the changelog.

As for timeline, I'm planning on implementing this in late June when Eclipse 4.6 and Gradle 2.14 will be released, the combination of which should fix quite a few issues.

[sbrannen]

Hi @nedtwigg,

If I'm not mistaken, the proposal here would solve the problem raised by a user who is trying to build JUnit 5 on Windows: junit-team/junit5#398

Is my assumption correct?

Thanks in advance for feedback!

Sam

[sbrannen]

Also, no pressure... but are you still planning on releasing Spotless 2.0 in the near future?

[nedtwigg]

Hi @sbrannen! I just finished up goomph, which makes it easier for Spotless to get new versions of Eclipse (namely neon).

With that finished, my task list is:

• incorporate neon (seems a few things are now broken)
• support .gitattributes

Looking at the linked bug, I think Spotless 2.0 will not fix it automatically, and I think there's a way to fix it in Spotless 1.x. I replied on the issue itself.

[sbrannen]

Thanks for the prompt feedback!

Goomph sounds interesting. Seems you've been hard at work.

I followed your advice on the line ending issue in JUnit on Windows, and as far as I can tell... it works like a charm.

Cheers!

[nedtwigg]

Finally landed .gitattributes support in 2.0.0-SNAPSHOT. Ready for testing, see CHANGES.md for details.

[nedtwigg]

Fixed in 2.0.0.