Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor update to the contributing doc #707

Merged
merged 4 commits into from
Jul 16, 2020
Merged

Minor update to the contributing doc #707

merged 4 commits into from
Jul 16, 2020

Conversation

heyams
Copy link
Contributor

@heyams heyams commented Jul 15, 2020

No description provided.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jul 15, 2020 •
edited
Loading

CLA Check
The committers are authorized under a signed CLA.

@trask trask mentioned this pull request Jul 15, 2020
Closed
trask
trask reviewed Jul 15, 2020
View reviewed changes
Copy link
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @heyams!

Thanks for these fixes/additions 👍

A couple suggestions below.

CONTRIBUTING.md Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
heyams and others added 2 commits July 15, 2020 16:57
@heyams @trask
Update CONTRIBUTING.md
e35a654 
Set core.autocrlf locally.

Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
@heyams @trask
Update CONTRIBUTING.md
bd63533 
Add more clarity.

Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
anuraaga
anuraaga reviewed Jul 16, 2020
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
trask
trask approved these changes Jul 16, 2020
View reviewed changes
Copy link
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @heyams!

anuraaga
anuraaga approved these changes Jul 16, 2020
View reviewed changes
Copy link
Contributor

@anuraaga anuraaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@anuraaga anuraaga merged commit bbf5e75 into open-telemetry:master Jul 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trask trask trask approved these changes

@anuraaga anuraaga anuraaga approved these changes

@iNikem iNikem Awaiting requested review from iNikem

@jkwatson jkwatson Awaiting requested review from jkwatson

@tylerbenson tylerbenson Awaiting requested review from tylerbenson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@heyams @anuraaga @trask