formatAnnotations merges type and non-type annotations in records

[jskov]

I find that FormatAnnotationsStep works OK with annotations on fields/getters that follow the form mentioned in this note.

But I have started using records in my project and have code like this:

public record EnumsDto(
        @JsonbProperty("external") @Valid @Nullable ExternalEnum external,
        @JsonbProperty("externalLower") @Valid @Nullable ExternalLowerEnum externalLower,
...

The above is the formatAnnotations() output.

But it should (if I understand things correctly) be:

public record EnumsDto(
        @JsonbProperty("external")
        @Valid @Nullable ExternalEnum external,
        @JsonbProperty("externalLower")
        @Valid @Nullable ExternalLowerEnum externalLower,
...

But since there is no protection keyword (public/private) to separate the non-type annotations from the type-annotations, they all get merged into the same line by FormatAnnotationsStep.

This is observed with version Gradle Plugin v7.0.0.BETA4

[jskov]

I think this can be fixed simply by only stripping newlines from type-annotations.
And thus leaving them for unknown annotations (which does not happen now).

I will work on a patch for this.

[nedtwigg]

This is a breaking change that makes me nervous. If you can gate it behind a flag, then I can easily merge. If you can't, we need to consider the impact to existing users a bit. @mernst any thoughts?

[jskov]

Sounds reasonable.