Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Prettier for maven #435

Closed
uweschaefer opened this issue Aug 19, 2019 · 3 comments
Closed

Feature Request: Prettier for maven #435

uweschaefer opened this issue Aug 19, 2019 · 3 comments

Comments

@uweschaefer
Copy link

i noticed that npm.PrettierFormatterStep and npm.TsFmtFormatterStep are not supported from maven. Is there some technical reason for that, or was it just not needed by now?

@nedtwigg
Copy link
Member

No technical reason. Everything in Spotless is there because someone added a feature that they needed for themselves. Happy to take a PR to add this.

Many projects get harder to work on as they get bigger. One of the things we do to keep Spotless easy to work on is that we don't require contributors to "fill the matrix". If you want to add Bazel support, we'd happily accept the PR even if it only supported one formatter. And if you want to add FooFormatter support, we'll happily accept the PR even if it only supports one build system.

Once someone has filled in one square of the formatter/build system matrix, it's easy for interested parties to fill in any empty squares, since you'll now have a working example for every piece needed.

@uweschaefer
Copy link
Author

i see. i'll try to provide a PR, then. Thanks!

nedtwigg added a commit that referenced this issue Aug 20, 2019
@nedtwigg
Copy link
Member

nedtwigg commented May 6, 2020

Closed by #55, available in maven-plugin since 1.30.0

@nedtwigg nedtwigg closed this as completed May 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants