Feature Request: Prettier: pass "filepath" to prettier in order to make it use the right parser #448
Labels
Comments
uweschaefer
changed the title
uweschaefer
added a commit
to uweschaefer/spotless
that referenced
this issue
Aug 30, 2019
… in order to enable choosing the right parser. see diffplug#448
uweschaefer
added a commit
to uweschaefer/spotless
that referenced
this issue
Aug 30, 2019
|
Thanks for the issue and PR! First off, there is currently a workaround: spotless {
format 'sass', {
target 'src/**/*.scss'
prettier().config(['parser': 'postcss'])
}
format 'js', {
target 'src/**/*.js'
prettier().config(['parser': 'babel'])
}
}The advantage of the current approach is you can pick which parser to use in cases where there are multiple, for example spotless {
format 'webResources', {
target 'src/**'
prettier().configAutoDetectFromExtension()
}
}Or maybe |
|
I tried to apply the mentioned workaround. I does not seem to work though, due to The problem persist with any recent version of the spotless gradle plugin. What am i missing? |
|
The important part of your stacktrace is this: which is a dup of #302. From that issue:
I like your "filepath" modification and think it would be an improvement for a lot of people, but it's a separate issue from #302. I don't mind if you resolve them both with a single PR ;-) |
|
Released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently, PrettierFormatterStep calls prettier passing the static configuration to it. In order to be able to format different types of files in one go (*.js, *.tx, *.css, *.html...) prettier needs to know on every invocation, what parser it should use.
This change is independent of the Build System used and involves PrettierFormatterStep::createFormatterFunc
I'll try to prepare a PR accordingly.
The text was updated successfully, but these errors were encountered: