gradle: resolve plugin dependencies via buildscript repositories not … #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like a few tests will need buildscript {
repositories { mavenCentral() }
}I guess Gradle testkit doesn't use any repositories by default. |
... not via project repositories
nedtwigg
reviewed
Apr 11, 2017
| @@ -3,6 +3,7 @@ | |||
| ### Version 3.3.0-SNAPSHOT - TBD ([javadoc](https://diffplug.github.io/spotless/javadoc/snapshot/), [snapshot](https://oss.sonatype.org/content/repositories/snapshots/com/diffplug/spotless/spotless-plugin-gradle/)) | |||
|
|
|||
| * Added support for groovy formatting (huge thanks to Frank Vennemeyer! [#94](https://github.com/diffplug/spotless/pull/94), [#89](https://github.com/diffplug/spotless/pull/89), [#88](https://github.com/diffplug/spotless/pull/88), [#85](https://github.com/diffplug/spotless/pull/85)) | |||
| * When special-purpose formatters need to be downloaded from maven, they are now resolved using the buildscript repositories rather than the project repositories. (thanks to [cal101](https://github.com/cal101) [#100](https://github.com/diffplug/spotless/pull/100)) | |||
|
|
|||
There was a problem hiding this comment.
Did I attribute you correctly? Happy to use a different name besides cal101 or a different link besides your github profile.
There was a problem hiding this comment.
Attribute as you like.
Typo in your first message "our" -> "out".
|
Looks great! I just tweaked some error message handling that your PR brought to light. When you get a chance, signoff on the attribution I used above and I'll merge & ship. |
|
How do you expect it to be signed off? |
|
No GPG sign or anything, just a comment that I picked the right name. Merge-ho! |
|
It'll be in 3.3.0-SNAPSHOT once the CI finishes, and I'll release 3.3.0 later today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…via project repositories (#99)