Fix conflicts between Spotless and Android re: clean task

[nedtwigg]

Spotless eagerly applies BasePlugin for the purpose of creating the clean task. This causes a problem for users who define their own clean task, which the Android template recommends.

Now we don't have to anymore, because we find it lazily (and without triggering configuration) like so:

spotless/plugin-gradle/src/main/java/com/diffplug/gradle/spotless/SpotlessPlugin.java

Lines 56 to 62 in 581215b

	static void configureCleanTask(Project project, Consumer<Delete> onClean) {
	project.getTasks().withType(Delete.class).configureEach(clean -> {
	if (clean.getName().equals(BasePlugin.CLEAN_TASK_NAME)) {
	onClean.accept(clean);
	}
	});
	}

[jbduncan]

Wow, I've just been down the rabbit hole that is issue #429!

To summarise, it looks like our ktlint test was flaking for a long time because it was using JCenter to download ktlint, and switching to Maven Central on main fixed that?

I also understand that this flakiness was aggravated at one point by our use of detached configurations in GradleProvisioner, which was making projects using Spotless and Gradle's parallelism support throw mysterious exceptions half the time? Although I understand that this was fixed back in Spotless 5, when we replaced our detached configurations with named ones.

So I suppose my only query is: will the @Disabled annotation in this PR be removed after this PR is merged in?

If so, then I have no other concerns. The rest of this PR LGTM! 👍

[jbduncan]

Other than the @Disabled annotation in the ktlint test file, this PR looks good to me.

[nedtwigg]

will the @disabled annotation in this PR be removed after this PR is merged in?

No. We are using the gradle retry plugin so that flaky dependency resolutions get a chance to retry. But even with that, we still got a failure, but only on shyiko

https://app.circleci.com/pipelines/github/diffplug/spotless/1518/workflows/2a6d9e93-1482-487e-ad96-98ab9d9a0872/jobs/8664

The shyiko stuff is quite old, ktlint has lived at com.pinterest for a few years now, so I'm hesitant to put much time into tracking it down.

[jbduncan]

The shyiko stuff is quite old, ktlint has lived at com.pinterest for a few years now, so I'm hesitant to put much time into tracking it down.

Ah okay, I understand. This seems acceptable to me, then. LGTM. :)

[nedtwigg]

Shipped in plugin-gradle/6.0.3.

[nedtwigg]

This PR was ultimately reverted in 6.5.0 by #1179 in response to user story #1164.