Remove Java files from default Maven Groovy formatting #1051
Conversation
lutovich
force-pushed
the
maven-groovy-no-format-java
branch
from
13515b5
to
a86b228
Compare
|
It feels like Groovy formatters should not touch Java files by default. However, I do not know much about the groovy-eclipse formatter. This might be a backward-incompatible change. Any input is much appreciated! |
|
Hi @bitwiseman, could you please take a look at this PR and the associated issue? Thanks! |
All Groovy formatters will default to formatting only the following files: * src/main/groovy/**/*.groovy * src/test/groovy/**/*.groovy They will not touch any .*java files. Fixes diffplug#902.
lutovich
force-pushed
the
maven-groovy-no-format-java
branch
from
a86b228
to
637f162
Compare
plugin-maven/CHANGES.md
Outdated
| * Before `3.0.0`, the default target of groovy was | ||
| * `src/main/groovy/**/*.groovy` | ||
| * `src/test/groovy/**/*.groovy` | ||
| * `src/main/groovy/**/*.java` |
There was a problem hiding this comment.
Just a small correction. I removed the following file masks:
src/main/java/**/*.javasrc/test/java/**/*.java
The Groovy formatter tried to format Java sources that live under the Java sources root. I think it is weird and perhaps even undesirable to format such source files with a Groovy formatter. This PR changes the default behavior, but it is more like a fix in my opinion.
There was a problem hiding this comment.
Oh man that is super weird! It's so weird my brain couldn't read it the first time, thanks for pointing that out! I always agreed that it was a fix, but now I also agree that it is not a "breaking fix".
…hat it is no longer a "breaking fix".
|
Thank you @nedtwigg! I'll merge this PR. |
|
|
|
Released in |
All Groovy formatters will default to formatting only the following files:
src/main/groovy/**/*.groovysrc/test/groovy/**/*.groovyThey will not touch any
.*javafiles.Fixes #902.