Wildcard targets are now tolerant of flatIncude subprojects (#121). #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbduncan
reviewed
Jun 20, 2017
| * Returns the relative path between root and dest, | ||
| * or null if dest is not a child of root. | ||
| */ | ||
| @Nullable |
There was a problem hiding this comment.
I'd argue that the @Nullable should be placed between the static and String on the next line for Java 8 style points, but it's a very small nitpick. Everything else LGTM!
There was a problem hiding this comment.
Sweet! That's where I wanted it to be, but I thought Java didn't let me do that. Turns out it does! Fixed in the next commit, once it passes CI I'll merge so that @regrog can use 3.5.0-SNAPSHOT.
|
Looks better! Ta. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.