Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix kotlinGradle throwing ParseException #133

Merged
merged 1 commit into from
Aug 14, 2017
Merged

Fix kotlinGradle throwing ParseException #133

merged 1 commit into from
Aug 14, 2017

Conversation

JLLeitschuh
Copy link
Member

Closes #132

Copy link
Member

@nedtwigg nedtwigg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The magic boolean parameter on KtLinStep is bad for the public API, but okay for the implementation.

Maybe something like this?

public create(String version, Provisioner provisioner)
public createScript(String version, Provisioner provisioner)
private create(String version,  Provisioner provisioner, boolean isScript)

@jbduncan
Copy link
Member

@nedtwigg What do you think about naming the createScript method forScript or createForScript? IMO, that would read a bit more fluently.

@nedtwigg
Copy link
Member

nedtwigg commented Aug 14, 2017

good call, createForScript is better

@JLLeitschuh
Copy link
Member Author

I was thinking about using an enum but decided to wait for your feedback before implementing that. I think the different method name is a better solution. Good call.

@JLLeitschuh
Copy link
Member Author

Should be fixed now.

@nedtwigg
Copy link
Member

LGTM! In the future, I would recommend updating PR's by adding new commits, rather than force-pushing. It's easier to track the conversation that way, and it's always possible to squash the commits at the end. Thanks for the fix! I'll release now.

@nedtwigg nedtwigg merged commit 8772ea6 into diffplug:master Aug 14, 2017
@JLLeitschuh
Copy link
Member Author

Ooooh. Thank you for performing a quick release for me! You are a solid group of maintainers!

@JLLeitschuh JLLeitschuh deleted the fix/kotlinGradle_fail_on_format branch August 14, 2017 19:46
@nedtwigg
Copy link
Member

Thanks for getting our kotlin support up-to-stuff! Available now as 3.5.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants