-
Notifications
You must be signed in to change notification settings - Fork 459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix kotlinGradle throwing ParseException #133
Fix kotlinGradle throwing ParseException #133
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The magic boolean parameter on KtLinStep
is bad for the public API, but okay for the implementation.
Maybe something like this?
public create(String version, Provisioner provisioner)
public createScript(String version, Provisioner provisioner)
private create(String version, Provisioner provisioner, boolean isScript)
@nedtwigg What do you think about naming the |
good call, |
I was thinking about using an enum but decided to wait for your feedback before implementing that. I think the different method name is a better solution. Good call. |
Should be fixed now. |
LGTM! In the future, I would recommend updating PR's by adding new commits, rather than force-pushing. It's easier to track the conversation that way, and it's always possible to squash the commits at the end. Thanks for the fix! I'll release now. |
Ooooh. Thank you for performing a quick release for me! You are a solid group of maintainers! |
Thanks for getting our kotlin support up-to-stuff! Available now as |
Closes #132