Add support for KtLint 0.48.0 (fixes #1430) #1432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidburstrom
force-pushed
the
main-ktlint-0.48.0
branch
from
2e00cfa to
f5af503
Compare
bcmedeiros
reviewed
Dec 28, 2022
|
|
||
| // get complete list of supported properties in DefaultEditorConfigProperties.INSTANCE | ||
| List<EditorConfigProperty<?>> editorConfigProperties = new ArrayList<>(DefaultEditorConfigProperties.INSTANCE.getEditorConfigProperties()); | ||
| editorConfigProperties.add(DefaultEditorConfigProperties.INSTANCE.getKtlintDisabledRulesProperty()); |
There was a problem hiding this comment.
I think ktlint_disabled_rules has been added to DefaultEditorConfigProperties in 0.48.0, already, so this whole new ArrayList part would be useless now. I introduced it in #1378 for a fix, but if it's in the DefaultEditorConfigProperties we can get rid of it.
There was a problem hiding this comment.
Thanks a ton @bcmedeiros for keeping an eye on this. @davidburstrom your call, I'm okay to merge it as-is, or if you want to make the change suggested above first I'm happy to wait.
There was a problem hiding this comment.
I'll take a look at the suggested change.
davidburstrom
force-pushed
the
main-ktlint-0.48.0
branch
from
f5af503 to
918547f
Compare
|
Needs a |
Closed
|
Released in |
|
Thanks for doing the final cleanup! |
Closed
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.